-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution]: Error icon shows on search bar while user search timelines with special characters. #138499
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
@samratbhadra-qasource If you hover over the error icon, does it show you an error message? |
I saw this yesterday on the I think is the text input is doing preemptive checks for an ElasticSearch query. and expecting closing characters if you put just 1 special character. Unsure if this should be considered a bug, as the there is a fair error message suggesting they have an unterminated possible elasticsearch query directive. If it is a bug, it might be to EUI to determine if that error catching should be there. If it's meant to be an only in memory table it might make sense to remove it since the query would never go to ElasticSearch, but at the same time, |
Hi @janmonschke Please do let us know if anything else if required from our end. Thanks! |
@jamster10 Yeah, hard to say if it is a bug. It's a good indicator for a wrong query but as the video shows, the query works just fine. |
This I don't know 🤔 . When I saw the behaviour elsewhere (other than the dashbaord) where I needed it, I assumed it was a known expected behavour. |
Tested in 8.9.0 BC5
Preconditions:
Describe the bug: Steps to reproduce:
Current behavior: Expected behavior: Error icon should not 🔺 display in search bar when searching for timeline name with special characters Observations:
Screenshots of behavior:Screenshot of timeline name search containing special characters with the error 🔺 icon displayed: Screenshot of timeline name search containing alphanumeric characters (No error 🔺 icon displays): Screenshot of timeline name search containing alpha characters (No error 🔺 icon displays): Screen share recording:timeline.error.icon.for.search.bar.with.special.character.names.mp4Conclusion:
@MadameSheema @michaelolo24 @janmonschke Updated FYI Observations |
@cybersecdiva This appears to be an issue in EUI itself. The issue can be reproduced here by typing in The best way to proceed is to involve the EUI team imo. |
For tracking purposes, the associated EUI issue is this one: elastic/eui#7160 |
After talking to the team, this is an issue with the EUI component we're using, therefore we're likely not the only ones facing the problem. There isn't an easy fix for this... like @janmonschke suggested, we probably could move away from that component and add our own validation, but he also said that that wouldn't make much sense, and I agree with him. I'm closing this ticket as this is an edge case and it seems that not many users have noticed it or cared enough about it to comment on this ticket or create new ones. |
Describe the bug:
Error icon shows on search bar while user search timelines with special characters.
Build Details:
Preconditions
Steps to Reproduce
Note: The same issue is reproducible for timelines templates.
Actual Result
Error icon shows on search bar while user search timelines with special characters.
Expected Result
Error icon should not show on search bar while user search timelines with special characters.
Screen-Recording:
Timelines.-.Kibana.-.Google.Chrome.2022-08-09.17-35-02.mp4
The text was updated successfully, but these errors were encountered: