Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] [Controls] Selecting option in view mode causes unsaved changes bug in edit mode #143671

Closed
Heenawter opened this issue Oct 19, 2022 · 4 comments · Fixed by #142780
Closed

[Dashboard] [Controls] Selecting option in view mode causes unsaved changes bug in edit mode #143671

Heenawter opened this issue Oct 19, 2022 · 4 comments · Fixed by #142780
Assignees
@Heenawter
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the bug:

When making a selection on an options list in view mode and then switching to edit mode, unselecting those options will not clear unsaved changes as it should.

Steps to reproduce:

  1. Open a sample dashboard in view mode
  2. Make a selection on one of the controls
  3. Switch to edit mode
  4. Notice that the unsaved changes badge shows up, as expected
  5. Unselect the option from step 1
  6. Notice that the unsaved changes badge is not cleared, even though it should be 🔥

Screenshots (if relevant):

Screen.Recording.2022-10-19.at.9.07.04.AM.mov
@Heenawter Heenawter added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 19, 2022
@kibanamachine kibanamachine added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Oct 19, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 19, 2022
@ThomThomson
Copy link
Contributor

I wonder if this is the bug that you found in #140739 ?

@Heenawter
Copy link
Contributor Author

Heenawter commented Oct 19, 2022 •
edited
Loading

@ThomThomson It totally is, sorry! Didn't make the connection.

I'll likely be fixing this in #142780 because I had to introduce that custom diffing system anyway, and it seems like this bug is caused by (from a very early investigation) an empty array being "different" than the undefined key :P

@ThomThomson
Copy link
Contributor

Hahaha of course! We really do need to move this diffing over to the embeddable side...

@Heenawter Heenawter mentioned this issue Oct 19, 2022
Merged
7 tasks
@Heenawter Heenawter added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Oct 19, 2022
@Heenawter Heenawter self-assigned this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] [Controls] Add excludes toggle to options list Heenawter/kibana
4 participants
@Heenawter @ThomThomson @elasticmachine @kibanamachine