Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run embeddable migrations on read only #147445

Closed
rudolf opened this issue Dec 13, 2022 · 2 comments · Fixed by #153117
Closed

Run embeddable migrations on read only #147445

rudolf opened this issue Dec 13, 2022 · 2 comments · Fixed by #153117
Assignees
Labels
Epic:ScaleMigrations Scale upgrade migrations to millions of saved objects Feature:Migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@rudolf
Copy link
Contributor

rudolf commented Dec 13, 2022

As part of #144035 we want to split saved objects into their own indices #104081. The goal here is to prevent a migration of one type of saved object from impact all other saved objects.

Because cases embeds lens visualisations, should lens ever specify an embeddable migration, we would also have to upgrade all cases. This means we're not achieving the isolation we hoped to achieve.

Because of the sharing to multiple spaces migration that rewrote _id's we had to extract the references inside all embeddables and migrate all embeddables to ensure that rewritten _ids were updated inside the embeddables too.

Given that we're no longer going to allow new types to do a convertToMultiNamespaceType migration #147344 there should be no reason to to migrate the embedded documents. We could keep embedded documents in their old version and only migrate them on reading. This means we can't query the embedded documents for e.g. telemetry (already an anti-pattern) but the plugin that e.g. renders that embeddable will always receive the embeddable SO as the latest version.

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Migrations labels Dec 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@exalate-issue-sync exalate-issue-sync bot changed the title Run embeddable migrations on read only Design: Run embeddable migrations on read only Dec 20, 2022
@rudolf
Copy link
Contributor Author

rudolf commented Jan 27, 2023

Screenshot 2023-01-11 at 11 42 31

@rudolf rudolf changed the title Design: Run embeddable migrations on read only Run embeddable migrations on read only Jan 27, 2023
@rudolf rudolf added the Epic:ScaleMigrations Scale upgrade migrations to millions of saved objects label Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic:ScaleMigrations Scale upgrade migrations to millions of saved objects Feature:Migrations Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants