Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][Alerting] Don't generate temporary data views for persisted data views #158729

Open
kertal opened this issue May 31, 2023 · 1 comment
Labels
chore Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@kertal
Copy link
Member

kertal commented May 31, 2023

In #146403 we migrated all alert notification context links to use Discover's locator. For persisted data views we were also creating temporary data views, so these links were snapshots of the data view when the notification was triggered (data views could be changed between the creation of the context link and when the users opens the link). However this caused an issue that links can get very long that was partly resolved by #158582 reducing the spec of a data view be removing field counts (those are used to show popular fields in Discover's field list) .

We can further shorten this generated link by using just the id of the persisted data view, which makes adding the spec of the data view redundant. In this case, we need to inform the user that the given result might be different to the one that triggered the alert notification (there might be more fields, change of the index pattern, change of field formats). The disadvantage of increasing the likelihood of showing different data can be considered as a lower impact than a broken link because of a very long link due to a spec.

The message we need to extend is here:

Some documents might have been added or deleted.`,

It could be extended like this:
Old:
Some documents might have been added or deleted
New:
Some documents might have been added or deleted or the underlying data view might have been changed

@kertal kertal added chore Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels May 31, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added medium impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed medium labels May 31, 2023
@jughosta jughosta removed their assignment Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Discover Discover Application impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

3 participants