Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to configure max_analyzed_offset in highlight request #159391

Closed
Tracked by #166068
dcolazin opened this issue Jun 9, 2023 · 5 comments
Closed
Tracked by #166068

Possibility to configure max_analyzed_offset in highlight request #159391

dcolazin opened this issue Jun 9, 2023 · 5 comments
Labels
enhancement New value added to drive a business result Feature:FieldFormatters Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@dcolazin
Copy link
Contributor

dcolazin commented Jun 9, 2023

Describe the feature: currently, if highlighting is enabled, Kibana performs an highlight request with only "pre_tags", "post_tags", "fields" and "fragment_size" attributes when querying Elastic. There are many other attributes that might be useful to configure for an highlight request. In my case, "max_analyzed_offset" would be very useful to bypass the shard failures when the searched field is longer than the index setting (default 1000000) without disabling highlighting in Kibana or changing the config on Elastic that might degrade performance (increase the default index setting, using offsets or term vectors).

Describe a specific use case for the feature: with a default of 1000000 (or 999999 if we are scared by off-by-one errors!), it will possible to completely avoid shard failures (if also Elastic config is set to default) in case of fields longer than 1MB. Even without setting a default, it will be possible to readily solve the issue on Kibana-side.

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 9, 2023
@davismcphee davismcphee added Feature:Search Querying infrastructure in Kibana enhancement New value added to drive a business result Feature:FieldFormatters Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed needs-team Issues missing a team label labels Jun 14, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@lukasolson lukasolson added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 2, 2023
@kertal
Copy link
Member

kertal commented Oct 30, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal added the Icebox label Oct 30, 2023
@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
@dcolazin
Copy link
Contributor Author

dcolazin commented Nov 16, 2023

Quite sad to see Kibana not supporting a straightforward Elasticsearch feature as "not planned"...

@kertal
Copy link
Member

kertal commented Nov 20, 2023

@dcolazin it's currently not planned, we agree it makes sense, but we currently can't provide a realistic implementation path for it. Also for this feature we'd need to provide UI, or would this be a general configuration option for all highlight requests?

@iamgd67
Copy link

iamgd67 commented Aug 27, 2024

may close by #191384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:FieldFormatters Feature:Search Querying infrastructure in Kibana Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants