Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens][ES|QL] Re-running the query should keep the selected configuration if possible #186366

Open
stratoula opened this issue Jun 18, 2024 · 5 comments
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Jun 18, 2024

Describe the feature:

Right now, every time a user submits a query in the editor, the Lens suggestions api runs and suggests a new chart. This results in changed made in the visualization level to be lost.

It would be cool if we could at least prioritize the activeVisualization chart Type and some of the configuration if is valid. The type will be very easy as the suggestions api can already do it (with the preferredChartType property). The visualization state is lost though (colors, legend settings etc).

We need to:

  • ask from the suggestions api to prirotize the current visualizationType
  • check if the query hasn't introduced major changes in the columns (check that the used columns in the datasourceState are being returned from the new query and in that case not change the chart (so keep the config)
  • if the columns are different we can just keep the visualization type and render the attributes returned from the suggestions api.
@stratoula stratoula added Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jun 18, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added the enhancement New value added to drive a business result label Jun 18, 2024
@stratoula
Copy link
Contributor Author

stratoula commented Jun 18, 2024

As a feature related to ES|QL and of a mid - high impact I am adding this on the ES|QL project team roadmap. Related to #184631

@stratoula stratoula changed the title [Lens][ES|QL] Re-running the query should keep the selected chart type if possible [Lens][ES|QL] Re-running the query should keep the selected configuration if possible Sep 23, 2024
@stratoula
Copy link
Contributor Author

I think that this needs to wait for the Lens embeddable refactor

@markov00
Copy link
Member

this is unblocked now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants