Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract queue from Knowledge base #191640

Closed
sorenlouv opened this issue Aug 28, 2024 · 1 comment
Closed

Extract queue from Knowledge base #191640

sorenlouv opened this issue Aug 28, 2024 · 1 comment
Labels
Team:Obs AI Assistant Observability AI Assistant technical debt Improvement of the software architecture and operational architecture

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Aug 28, 2024

Background
When adding pre-loaded knowledge base entries (like Lens docs) we need to wait for the Knowledge Base (aka Elser model) to be available before writing and make sure that only a single Kibana instance ingests the documents in order to avoid spamming the cluster with duplicate entries.

We currently use the task manager and a custom queue to handles this. The current implementation adds complexity to the knowledge base, making it harder to make changes and write tests for this. I suggest we extract the queuing logic from the knowledge base. If needed we can create a completely separate queuing service or better look into getting rid of the queue completely.

The queue is implemented in the following services:

Acceptance criteria

  • Pre-loaded entries should await ingesting until knowledge base is ready (queue or no queue?)
  • Pre-loaded entries should only be ingested by a single kibana instance. (the task manager can handle this for us)
  • Long entries should be chunked (split into smaller docs). This will (eventually) be handled automatically by semantic_text for both pre-loaded and user created entries
  • The API should throw an error if a client attempts to add an entry before knowledge base is ready (status quo).

Depends on: #186499

@sorenlouv sorenlouv added Team:Obs AI Assistant Observability AI Assistant technical debt Improvement of the software architecture and operational architecture labels Aug 28, 2024
@sorenlouv
Copy link
Member Author

The queue was removed in #191043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs AI Assistant Observability AI Assistant technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

1 participant