-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Explore][EUI visual refresh] make sure color palettes are theme aware #202498
Comments
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Todos:
kibana/x-pack/plugins/security_solution/public/explore/hosts/components/kpi_hosts/types.ts Lines 14 to 16 in b845917
Line 28 in b845917
Line 41 in b845917
Lines 22 to 23 in b845917
kibana/x-pack/plugins/security_solution/public/common/components/matrix_histogram/utils.ts Line 11 in b845917
Line 40 in 4a2f63c
Line 88 in 8c4976f
Line 96 in 0d8a1ec
Line 42 in 250790e
Line 21 in b845917
Map: Others:
Rules migration:Lines 28 to 30 in 668f776
alerts:Line 102 in df15fe1
kibana/x-pack/plugins/security_solution/public/common/components/severity_badge/index.tsx Lines 17 to 20 in c3801ce
kibana/x-pack/plugins/security_solution/public/common/constants.ts Lines 10 to 13 in d39c75a
|
Context
Changes are made to EUI that will be visible to end-users in Kibana:
These changes are available in a new theme called Borealis.
See parent ticket for how to use the new theme and labels to add to the PR for tracking
Description
All usage of color palette tokens and functions now pull from the theme, and correctly update to use new colors when the theme changes from Borealis to Amsterdam and vice versa.
Important
Key point: Make sure that if you are using colors from our color palette options, that your UI correctly updates to use the correct colors whenever you change themes.
https://eui.elastic.co/#/utilities/color-palettes
Vis color tokens are now available through the EUI theme:
euiTheme.colors.vis
:These were not previously part of the theme. This means that they would not change when the theme was changed. They are now part of the theme and should change when the theme is changed.
If you were using any of the above tokens directly, please change your code to pull them directly from
euiTheme.colors.vis
.If you were using any of our color palette functions:
EuiProvider
context and is hence connected to rerender (called on rerender or connected to a state)EuiProvider
context you can use the newEUI_VIS_COLOR_STORE.subscribe()
function to listen to changes and update usages manuallyThe text was updated successfully, but these errors were encountered: