-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Field type icon without contrast #202760
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
I think the icon we get is already colored by Eui https://eui.elastic.co/#/display/icons#tokens |
Thanks team, it looks like it might be the EUI team, I'm in talks in slack atm :) |
Latest news: these colors are not preset/provided by EuiToken (it accepts any color with the docs suggesting data viz colors), so this would be a Kibana (implementor) level change |
For consistency it would make more sense if Eui would manage (continue managing) the mapping between the token and its color. It's not only Discover where it's being used without Is not it implemented in https://github.com/elastic/eui/blob/main/packages/eui/src/components/token/token_map.ts ? |
++ to what @jughosta said. These tokens are currently used across Kibana and ideally we'd be able to rely on the default styling to provide a good experience everywhere (and only carve out exceptions with custom styling when really needed). If it must be done Kibana side for Borealis, it should be done in a global way so all Kibana usages inherit it by default, but I still feel it would be better to be able to rely on the defaults as we do with Amsterdam. |
I confirmed with @ryankeairns that this will be addressed on the EUI side, and linked their private issue to this one for reference. |
Pinging @elastic/eui-team (EUI) |
Re-opening; will close when EUI PR merges |
EUI PR merged. This will be part of the pending upgrade: #204482 |
Accent color on light background doesn't have enough contrast:
The text was updated successfully, but these errors were encountered: