Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Field type icon without contrast #202760

Closed
l-suarez opened this issue Dec 3, 2024 · 12 comments
Closed

[Discover] Field type icon without contrast #202760

l-suarez opened this issue Dec 3, 2024 · 12 comments
Assignees
Labels
EUI Visual Refresh EUI Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@l-suarez
Copy link

l-suarez commented Dec 3, 2024

Accent color on light background doesn't have enough contrast:
Image
Image

@l-suarez l-suarez self-assigned this Dec 3, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 3, 2024
@kertal kertal added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Dec 9, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Dec 9, 2024

@l-suarez I assume this has to be fixed on EUI side? of should we change the background of the field list? FYI @jughosta

@jughosta
Copy link
Contributor

jughosta commented Dec 9, 2024

I think the icon we get is already colored by Eui https://eui.elastic.co/#/display/icons#tokens

@kertal
Copy link
Member

kertal commented Dec 9, 2024

@jughosta thx!
so we've got 2 options

  1. EUI changes the icon
  2. We change the background

@l-suarez wdyt?

@l-suarez
Copy link
Author

l-suarez commented Dec 9, 2024

Thanks team, it looks like it might be the EUI team, I'm in talks in slack atm :)

@l-suarez
Copy link
Author

l-suarez commented Dec 9, 2024

Latest news: these colors are not preset/provided by EuiToken (it accepts any color with the docs suggesting data viz colors), so this would be a Kibana (implementor) level change

@jughosta
Copy link
Contributor

jughosta commented Dec 9, 2024

For consistency it would make more sense if Eui would manage (continue managing) the mapping between the token and its color. It's not only Discover where it's being used without fill property.

Is not it implemented in https://github.com/elastic/eui/blob/main/packages/eui/src/components/token/token_map.ts ?

@davismcphee
Copy link
Contributor

++ to what @jughosta said. These tokens are currently used across Kibana and ideally we'd be able to rely on the default styling to provide a good experience everywhere (and only carve out exceptions with custom styling when really needed). If it must be done Kibana side for Borealis, it should be done in a global way so all Kibana usages inherit it by default, but I still feel it would be better to be able to rely on the defaults as we do with Amsterdam.

@davismcphee
Copy link
Contributor

I confirmed with @ryankeairns that this will be addressed on the EUI side, and linked their private issue to this one for reference.

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@ryankeairns
Copy link
Contributor

Re-opening; will close when EUI PR merges

@ryankeairns ryankeairns reopened this Dec 18, 2024
@ryankeairns
Copy link
Contributor

EUI PR merged. This will be part of the pending upgrade: #204482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EUI Visual Refresh EUI Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

No branches or pull requests

7 participants