Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] DT design polish #24475

Closed
12 tasks done
formgeist opened this issue Oct 24, 2018 · 19 comments
Closed
12 tasks done

[APM] DT design polish #24475

formgeist opened this issue Oct 24, 2018 · 19 comments
Assignees
Labels
Team:APM All issues that need APM UI Team support v6.5.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Oct 24, 2018

Note: I'm starting in on this (Jason), please ping me before you start on any of this work, we can work out how to split it up. Will be working on branch `jasonrhodes:polish-6.5


✅ Span row design update

In order to make it clearer to the user that there's a difference between transactions and spans in the Timeline (and since they open different information flyouts), I would prefer to make some minor updates to the appearance of transaction and span rows in the visualization.

row-spans-update

  • Change transaction rows font styling
    • Propose to use the EuiText h4 styling. It will render close to font-family: font-family: "Open Sans", Helvetica, Arial, sans-serif; font-size: 1rem; font-weight: 600; Not sure if there'll be issues with margins using the h4 styling inside the row.
  • Show EuiIcon merge in front of transactions span rows.

We can keep the span rows as they are.


✅ Remove Transaction sample panel deep shadow

screenshot 2018-10-24 at 10 16 24

  • hasShadow should be changed to false so we avoid the deeper shadow on the panel.

✅Align heading styles

screenshot 2018-10-24 at 10 33 44

  • Change "Response time distribution" heading to the same style. We're using EuiTitle for the "Transaction sample" heading in the sample header, so perhaps adopt the same principles to these headings altogether. The style should be equal to the EuiTitle size xs for all three headings.

Transaction flyout

✅Change Flyout size to medium

screenshot 2018-10-24 at 10 11 36

  • Change Flyout size to m instead of l. It hides more of the background content than desired.
  • Add ownFocus={true} so that outside clicks close the flyout
  • Wrap flyout in EuiPortal so that the ownFocus treatment works correctly
  • Convert to EuiToolTip to fix bug with existing tooltip z-index

✅Remove the "View Transaction group detail" button from the header

screenshot 2018-10-25 at 10 26 17

  • Remove the button, as we already have a link on the Name value to the Transaction detail page for the particular transaction.

Span flyout

✅Change Flyout size to medium

screenshot 2018-10-24 at 10 11 09

  • Change Flyout size to m instead of l. It hides more of the background content than desired.
  • Add ownFocus={true} so that outside clicks close the flyout

✅Re-arrange sticky properties

In an effort to align the Transaction and Span flyout StickyProperties, so placement is the same when moving between them, I'm suggesting to make the following re-arranging of the properties;

screenshot 2018-10-25 at 10 09 19

  • Split the 4 properties related to the span into two rows, moving duration to the 2nd row along with % of transaction.
@formgeist formgeist added Team:APM All issues that need APM UI Team support v6.5.0 labels Oct 24, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@formgeist
Copy link
Contributor Author

@elastic/apm-ui First redline run-through of the UI. If I find more stuff, I'll add it to the description and add a comment here.

@formgeist
Copy link
Contributor Author

Added problem with StickyProperties component for an Error occurence on the Error group detail page.

@formgeist
Copy link
Contributor Author

Added another task around exchanging the icon in the search bar. It's a minor enhancement, but noticed it had changed in the other places (Discover, Visualize and Dashboards) so thought we should align.

@jasonrhodes
Copy link
Member

Gotten a bit more feedback about the flyouts and click-to-close stuff. I think we should turn on that white overlay so that those outside clicks are intercepted and cause the flyouts to close. In my opinion, we still get the advantage of the flyout making the user feel like they haven't left the timeline completely, but they don't actually need to see anything on the timeline when they are looking at the flyout, so this seems to work ok. @formgeist if you feel strongly about not going this way, let me know.

@jasonrhodes
Copy link
Member

Added: services legend needs to be fixed so that it only shows the services for the current tx instead of the entire trace

@jasonrhodes
Copy link
Member

@formgeist for the "Span row design update", you said "Show EuiIcon merge in front of transactions span rows." I assumed you meant "in front of transaction rows" and so I put strikethrough around span, lmk if I misinterpreted!

@formgeist
Copy link
Contributor Author

@jasonrhodes You presumed correctly! Didn't mean to write span in there... 👌

@formgeist
Copy link
Contributor Author

@jasonrhodes @sqren Re: the flyout ownFocus let's turn it on, because I've found that even I added it to the designs and InVision prototypes 🤯

@formgeist
Copy link
Contributor Author

Removed the task about changing the Searchbar icon to console because we can't change it easily in the Searchbar Eui component. The others are not using Eui, which is why it's easy for them to align and change the icon. We assume that they'll update the component soon enough, and we'll all switch over. Otherwise it's possibly something we'll change in the query bar component itself.

@jasonrhodes
Copy link
Member

Re: active/selected bucket ... we can't easily show this. Each bucket has an attached "sample" and it may or may not be the exact transaction we're loading on that group page when we link to a specific transaction now.

We could do some clever lookups to find which bucket's time range matches the selected transaction's duration, but that is probably more than just "polish"...

@sorenlouv
Copy link
Member

Re: active/selected bucket ... we can't easily show this. Each bucket has an attached "sample" and it may or may not be the exact transaction we're loading on that group page when we link to a specific transaction now.

We could do some clever lookups to find which bucket's time range matches the selected transaction's duration, but that is probably more than just "polish"...

Two solutions that come to mind:

  1. Highlight the bucket that matches the duration of the transaction. This is a bit cheating, but at least the user gets some indication where on the histogram spectrum the current sample lands.

  2. When fetching the histogram we can provide a transactionId, to ensure it ends up in a bucket as a sample. This would however require us to re-fetch the histogram whenever the transaction changes (which might not be an issue).

@jasonrhodes
Copy link
Member

@sqren @formgeist did you two talk about the agent marks stuff in this ticket? I think Søren moved the dots down on purpose for spacing purposes, but it sounds like Casper wants them back above the line with the x-axis labels moved up so they don't collide. That would push the x-axis labels up everywhere, even when there are no agent mark dots. Just clarifying that's what we want to do!

@formgeist
Copy link
Contributor Author

Adding another about adding a Services label in front of the services legend by the Timeline viz.

@formgeist
Copy link
Contributor Author

@jasonrhodes Re: agent mark dots, we agreed to move the x-axis label up 5px to make room for the dots to slide along the bottom of the x-axis line, as proposed in my issue above ^

@formgeist
Copy link
Contributor Author

Added a task to include the services legend in the locked x-axis when scrolling a large Timeline

@formgeist
Copy link
Contributor Author

Added a task to re-arrange the sticky properties in the Span flyout to align with the Transaction flyout when moving between them.

@formgeist
Copy link
Contributor Author

Added a task to remove the "View transaction group detail" button from the Transaction flyout header, as there's already a link in the properties to the transaction.

@formgeist
Copy link
Contributor Author

Continuing more polish tasks in this issue #24578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v6.5.0
Projects
None yet
Development

No branches or pull requests

5 participants