-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] DT design polish #24475
Comments
Pinging @elastic/apm-ui |
@elastic/apm-ui First redline run-through of the UI. If I find more stuff, I'll add it to the description and add a comment here. |
Added problem with StickyProperties component for an Error occurence on the Error group detail page. |
Added another task around exchanging the icon in the search bar. It's a minor enhancement, but noticed it had changed in the other places (Discover, Visualize and Dashboards) so thought we should align. |
Gotten a bit more feedback about the flyouts and click-to-close stuff. I think we should turn on that white overlay so that those outside clicks are intercepted and cause the flyouts to close. In my opinion, we still get the advantage of the flyout making the user feel like they haven't left the timeline completely, but they don't actually need to see anything on the timeline when they are looking at the flyout, so this seems to work ok. @formgeist if you feel strongly about not going this way, let me know. |
Added: services legend needs to be fixed so that it only shows the services for the current tx instead of the entire trace |
@formgeist for the "Span row design update", you said "Show EuiIcon |
@jasonrhodes You presumed correctly! Didn't mean to write span in there... 👌 |
@jasonrhodes @sqren Re: the flyout |
Removed the task about changing the Searchbar icon to |
Re: active/selected bucket ... we can't easily show this. Each bucket has an attached "sample" and it may or may not be the exact transaction we're loading on that group page when we link to a specific transaction now. We could do some clever lookups to find which bucket's time range matches the selected transaction's duration, but that is probably more than just "polish"... |
Two solutions that come to mind:
|
@sqren @formgeist did you two talk about the agent marks stuff in this ticket? I think Søren moved the dots down on purpose for spacing purposes, but it sounds like Casper wants them back above the line with the x-axis labels moved up so they don't collide. That would push the x-axis labels up everywhere, even when there are no agent mark dots. Just clarifying that's what we want to do! |
Adding another about adding a Services label in front of the services legend by the Timeline viz. |
@jasonrhodes Re: agent mark dots, we agreed to move the x-axis label up 5px to make room for the dots to slide along the bottom of the x-axis line, as proposed in my issue above ^ |
Added a task to include the services legend in the locked x-axis when scrolling a large Timeline |
Added a task to re-arrange the sticky properties in the Span flyout to align with the Transaction flyout when moving between them. |
Added a task to remove the "View transaction group detail" button from the Transaction flyout header, as there's already a link in the properties to the transaction. |
Continuing more polish tasks in this issue #24578 |
Note: I'm starting in on this (Jason), please ping me before you start on any of this work, we can work out how to split it up. Will be working on branch `jasonrhodes:polish-6.5
✅ Span row design update
In order to make it clearer to the user that there's a difference between transactions and spans in the Timeline (and since they open different information flyouts), I would prefer to make some minor updates to the appearance of transaction and span rows in the visualization.
font-family: font-family: "Open Sans", Helvetica, Arial, sans-serif; font-size: 1rem; font-weight: 600;
Not sure if there'll be issues with margins using theh4
styling inside the row.merge
in front of transactionsspanrows.We can keep the span rows as they are.
✅ Remove Transaction sample panel deep shadow
hasShadow
should be changed tofalse
so we avoid the deeper shadow on the panel.✅Align heading styles
EuiTitle
for the "Transaction sample" heading in the sample header, so perhaps adopt the same principles to these headings altogether. The style should be equal to theEuiTitle
sizexs
for all three headings.Transaction flyout
✅Change Flyout size to
medium
m
instead ofl
. It hides more of the background content than desired.ownFocus={true}
so that outside clicks close the flyout✅Remove the "View Transaction group detail" button from the header
Span flyout
✅Change Flyout size to
medium
m
instead ofl
. It hides more of the background content than desired.ownFocus={true}
so that outside clicks close the flyout✅Re-arrange sticky properties
In an effort to align the Transaction and Span flyout StickyProperties, so placement is the same when moving between them, I'm suggesting to make the following re-arranging of the properties;
The text was updated successfully, but these errors were encountered: