Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template service for Kibana document title #35210

Closed
timroes opened this issue Apr 17, 2019 · 7 comments
Closed

Template service for Kibana document title #35210

timroes opened this issue Apr 17, 2019 · 7 comments
Labels
enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@timroes
Copy link
Contributor

timroes commented Apr 17, 2019

We have a couple of issues and users asking for changing the document title. Some want to get rid of the dashboard name (#19468), some want more distinction or in general customization in the name (#31250).

I think to enable this we should enable two things:

  • Have an advanced setting, where you can specify a document title template including some placeholders (e.g. something like vscode has in its window.title setting). The user could then specify something like ${page} - ${app} - Kibana (Dev), and then would get a title like My Dashboard - Dashboard - Kibana (Dev) in that case.
  • Currently everyone blindly messes with document.title to set those, which would not work in that scenario anymore. I would suggest we're creating a core service, that you can then call from everywhere to set the value of those placeholders, so e.g. when opening a dashboard I would call core.document.setTitle({ app: 'Dashboard', page: 'My Dashboard' }), and this service would then use the configured template to build the title.

I would suggest the following placeholders to start with:

  • ${app} - App name (Dashboard, Visualize, Uptime, Management) - would be specified by the call to the core API
  • ${page} - Page name (My Dashboard/Vis Name, subpage like "Advanced Setting") - would be specified by the call to the core API
  • ${space} - Current Space name
  • ${user} - Current user name
  • ${instance} (or the like) - maybe some configurable instance name that can be specified in the kibana.yml
@timroes timroes added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc enhancement New value added to drive a business result labels Apr 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@alexfrancoeur
Copy link

Another request that just came through was to show the active filters in the dashboard title.

@shalvah
Copy link

shalvah commented Aug 8, 2019

👀

I know this isn't a super important feature, but it would really be nice to have this. We have multiple instances on Elastic Cloud, and when both Kibana tabs are open, it is very easy to mistake one for the other.

@timroes
Copy link
Contributor Author

timroes commented Sep 24, 2019

@joshdover is this now the application service is available somewhere on the roadmap or linked as part of it?

@myasonik
Copy link
Contributor

Having unique page titles everywhere would also resolve #11518 and generally help #42379

@joshdover
Copy link
Contributor

Nothing exists in the New Platform yet, but we have opened this issue: #46077 which is yet to be prioritized. One of the ideas that came up is leveraging the information already present in breadcrumbs to populate the document title automatically.

@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
@timroes
Copy link
Contributor Author

timroes commented Jan 15, 2021

@joshdover have we decided to not implement this, or is this now tracked buy some other issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

6 participants