Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Discover Search Field missing label #37526

Closed
barlowm opened this issue May 30, 2019 · 1 comment
Closed

(Accessibility) Discover Search Field missing label #37526

barlowm opened this issue May 30, 2019 · 1 comment

Comments

@barlowm
Copy link
Collaborator

barlowm commented May 30, 2019

Steps to reproduce

Inspect source of "search" field

Screen Shot:
Search_2

Source from inspection:
Search_1

Expected Result

There should be a visible label for the field, or an AT accessible label per WCAG guidelines (see below).

The search field DOES have an "aria-label=Search input".

However How to Meet WCAG 2 (Quick Reference) 3.3.2Labels or Instructions only indicates that the following ARIA attributes are sufficient:

G131: Providing descriptive labels using one of the following techniques:

Meta Issue:

Accessibility Audit for Kibana 7.0
Accessibility Make Kibana Discover Accessible for 7.0

Kibana Version:

7.0

Relevant WCAG Criteria:

WCAG Criterion

Guideline 3.3 – Input Assistance

3.3.2 Labels or Instructions - Level A

@myasonik
Copy link
Contributor

Talked with @rayafratkina and @timroes and we're going to close this issue.

I agree that adding an always visible label would improve this but I don't think we're at a place where this is the thing we want to be tackling (changing the UI here will require quite a bit of time). Once we're in a place where we're tackling issues like this one, I think we'll be able to identify it and reopen this issue but no need to let this sit on the vine, effectively, in perpetuity.

We could pedantically fulfill the spec by changing the aria-label to an aria-labelledby but I don't think that actually helps anyone if they label doesn't become visible along with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants