Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Time range <select> needs a valuable sound announcement #38794

Closed
PhilippBaranovskiy opened this issue Jun 12, 2019 · 6 comments
Closed

(Accessibility) Time range <select> needs a valuable sound announcement #38794

PhilippBaranovskiy opened this issue Jun 12, 2019 · 6 comments
Labels
Feature:Discover Discover Application Project:Accessibility WCAG A

Comments

@PhilippBaranovskiy
Copy link
Contributor

PhilippBaranovskiy commented Jun 12, 2019 •
edited
Loading

Steps to reproduce (assumes NVDA or VoiceOver)

  1. Go to Kibana => Discover
  2. Tab to time range select (see the screenshot)
  3. Listen to your screen reader

Actual Result

  1. screenreader reads it as "checkmark second"

Expected Result

  1. get this label of time interval box to read as timespan, as "timespan second"
@PhilippBaranovskiy PhilippBaranovskiy mentioned this issue Jun 12, 2019
Merged
2 tasks
@PhilippBaranovskiy
Copy link
Contributor Author

Related code here: src\legacy\core_plugins\kibana\public\discover\index.html:142,
js model: src\legacy\ui\public\agg_types\buckets\_interval_options.js

@bhavyarm
Copy link
Contributor

sure that works. Thanks @rockfield

@barlowm
Copy link
Collaborator

barlowm commented Jun 14, 2019

WCAG Criteria -
1.3.1 Info and Relationships
3.3.2 Labels or Instructions

@barlowm barlowm added the WCAG A label Jun 14, 2019
@PhilippBaranovskiy
Copy link
Contributor Author

@barlowm, could you clarify what exactly is not perfect here relatively to WCAG A?

@bhavyarm
Copy link
Contributor

@barlowm the original issue I logged was here: #19448

@myasonik myasonik mentioned this issue Oct 10, 2019
Merged
5 tasks
snide pushed a commit to elastic/eui that referenced this issue Oct 11, 2019
@snide
Fixes several a11y issues manifesting in Kibana (#2411)
f475ce9 
Fixes several of misc a11y issues showing up in Kibana:
- Poor labeling in `EuiSuperDatePicker` ([Kibana issue 38794](elastic/kibana#38794)) (this kind of snowballed into improving several things in the vicinity)
- Fixes #2416: `EuiFormRow`s that render fields that also render a label end up rendering multiple labels for an input which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing ([Kibana issue 43584](elastic/kibana#43584) )
- Fixes #2414: `EuiCodeEditor`s would render with the same ID which breaks many assistive tech (this issue was found during the in progress Kibana rollout of automated a11y testing)
@myasonik
Copy link
Contributor

Fixed by merging #48119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application Project:Accessibility WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@PhilippBaranovskiy @barlowm @myasonik @bhavyarm