How to handle render complete in custom renderers

[timroes]

We currently pass in a done handler into the expression renderer, if we call it via the visLoader. This done() handler must be called by the renderer, once it's done rendering, so the visLoader can set the data-render-complete attribute correctly for reporting.

We need to align that behavior for all renderers no matter how they are called. Following up from a discussion with @ppisljar my current suggestion would be:

• Make sure that every renderer gets passed in the done handler that it must call once done rendering, no matter if it's called via the Executor service or the visLoader, etc.
• Since we need the rendering done for all embeddables on a dashboard, the suggestion would be to also give embeddables a core concept of "done rendering". The visualization embeddable should then just pass the embeddable done function into the Executor service/vis loader, so it will be used instead one generated by the executor service/vis loader.
• Have a common utility for features that are not using the expression to render, and are not running inside an embeddable (at least in their own application), e.g. Maps. They can use that utility directly.
  Otherwise it will be used by the embeddable infrastructure when the embeddable done method is called (e.g. everything on a dashboard), or by the executor service, if no done handler is passed into the service from the outside (e.g. when running in Lens directly there is no embeddable wrapper, but the executor service is used directly).

cc @joelgriffith @tsullivan

[elasticmachine]

Pinging @elastic/kibana-app-arch

[tsullivan]

Apologies, but it looks like this important discussion is getting lost. Let's make sure we take it up.

For now, I'm just going to cc @mattkime

[elasticmachine]

Pinging @elastic/kibana-stack-services

[tsullivan]

I don't think this issue is related to Reporting. It looks more about how the core visualizations reach their render complete stage. The Reporting code is not going to change how it reads visualizations on the page, which is setting DOM event listeners on the visualization containers.

[ppisljar]

we have few tasks in common that might relate to this.

1. moving render-complete logic out of visualize loader into embeddable layer

• at the same time we could extract this into utility functions first before using it in embeddable layer

2. deprecating vis loader and making executor service the only way to run expressions (so done handler will always be passed in)

• at the same time we could make executor throw if done was not called for specific amount of time to make sure everyone implements calling it

[ppisljar]

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.