Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Kibana Infrastructure - aria-controls #41616

Closed
barlowm opened this issue Jul 19, 2019 · 6 comments · Fixed by #54512
Closed

(Accessibility) Kibana Infrastructure - aria-controls #41616

barlowm opened this issue Jul 19, 2019 · 6 comments · Fixed by #54512
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A

Comments

@barlowm
Copy link
Collaborator

barlowm commented Jul 19, 2019

@bhavyarm - This is the issue I mentioned during today's sync-up meeting.

Steps to reproduce

  1. Navigate to the Kibana Infrastructure page
  2. Select the "Default" button (euiHeaderSectionItem__button), examine source

aria-controls

<button 
	class="euiHeaderSectionItem__button" 
	type="button" 
	aria-controls="headerSpacesMenuList" 
	aria-expanded="false" 
	aria-haspopup="true" 
	aria-label="Default" 
	title="Default"
>

Control has an "aria-controls" attribute which doesn't point to anything.
This "should" point to one or more elements which are controlled by this button.

Meta Issue
Accessibility Audit for Kibana 7.0

Kibana Version:
7.3.0

OS:
Tested on Windows 7. But issue exists in all OS's

Browser:
Tested in Chrome. But issue exists in all Browsers

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1
Accordion Example
A toggle button

@bhavyarm bhavyarm added Feature:Metrics UI Metrics UI feature bug Fixes for quality problems that affect the customer experience labels Jul 22, 2019
@barlowm
Copy link
Collaborator Author

barlowm commented Jul 23, 2019

@myasonik - This is the one mentioned in slack

@bhavyarm bhavyarm added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! and removed Feature:Metrics UI Metrics UI feature labels Jul 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@bhavyarm
Copy link
Contributor

bhavyarm commented Jul 23, 2019

The error is here. Please note this is Kibana spaces bug:

<button class="euiHeaderSectionItem__button" type="button" aria-controls="headerSpacesMenuList" aria-expanded="false" aria-haspopup="true" aria-label="Default" title="Default"><div class="euiAvatar euiAvatar--s euiAvatar--space spaceNavGraphic" aria-label="Default" title="Default" data-test-subj="space-avatar-default" style="background-image: none; background-color: rgb(0, 191, 179); color: rgb(0, 0, 0);"></div></button>

Screen Shot 2019-07-23 at 1 18 10 PM

@myasonik
Copy link
Contributor

Did some digging and the issue is a bit larger than that. There are some issues in Kibana but it also implements EuiPopover which has some issues of its own. Will work on resolving but not certain on a timeline at this point.

@rayafratkina rayafratkina changed the title (Accessibility) Kibna Infrastructure - aria-controls (Accessibility) Kibana Infrastructure - aria-controls Nov 1, 2019
@snide
Copy link
Contributor

snide commented Nov 1, 2019

If there's an EUI problem here feel free to make a issue in that repo.

@myasonik
Copy link
Contributor

myasonik commented Nov 4, 2019

This issue in this ticket is actually in Kibana because it's coming from a header button which are a thin wrapper around HTML <button>s.

@snide The rest of the issues are the ones that we talked about in my long ago overlays doc which ... I don't remember if we ever made tickets out of those TODO items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! WCAG A
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants