Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Move context related code to common location #41763

Closed
4 tasks done
walterra opened this issue Jul 23, 2019 · 1 comment · Fixed by #42244
Closed
4 tasks done

[ML] Move context related code to common location #41763

walterra opened this issue Jul 23, 2019 · 1 comment · Fixed by #42244
Assignees
@walterra
Labels
:ml refactoring v7.4.0

Comments

@walterra
Copy link
Contributor

walterra commented Jul 23, 2019 •
edited
Loading

Follow up to #41343

  • Move context related code to a common location (context directory).
  • Put each context "group" into a directory (e.g. context/navigation, context/kibana).
  • Move mock data into their own files.
  • Try to come up with factories to group imports.
@walterra walterra self-assigned this Jul 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@walterra walterra mentioned this issue Jul 23, 2019
Merged
4 tasks
@walterra walterra mentioned this issue Jul 30, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walterra walterra

Labels
:ml refactoring v7.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Use context and custom hooks to manage legacy dependencies. walterra/kibana
3 participants
@walterra @peteharverson @elasticmachine