Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Tab links are broken in IE11 #45357

Closed
dgieselaar opened this issue Sep 11, 2019 · 6 comments · Fixed by #45371
Closed

[APM] Tab links are broken in IE11 #45357

dgieselaar opened this issue Sep 11, 2019 · 6 comments · Fixed by #45371
Assignees
Labels
bug Fixes for quality problems that affect the customer experience IE11 Team:APM All issues that need APM UI Team support

Comments

@dgieselaar
Copy link
Member

When clicking on a (EUI)Tab in the APM UI in IE11, nothing happens. This could be because we render an <a/> inside of a <button/>. If I change the <button/> to a <div/>, the tab works again.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@sorenlouv
Copy link
Member

sorenlouv commented Sep 11, 2019

If I change the to a

, the tab works again.

I thought EuiTab always wrapped the content in a button. Is it possible for us to change this?

@dgieselaar
Copy link
Member Author

No, not from what I can tell. A possible fix for us would be to render EUITab ourselves with the euiTab and euiTab__content classNames.

@dgieselaar
Copy link
Member Author

If you mean changing EUITab to support the possibility of rendering as a div (or even better, as an anchor), that would be the best solution, but probably hard to fix for 7.4.0.

@sorenlouv
Copy link
Member

If you mean changing EUITab to support the possibility of rendering as a div (or even better, as an anchor), that would be the best solution, but probably hard to fix for 7.4.0.

Yeah, that's what I meant. Agree, it won't happen for 7.4. Hopefully for 7.5 though if we flag it early.

@dgieselaar
Copy link
Member Author

well well well: elastic/eui#2275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience IE11 Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants