Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced settings require entry in src/ui/public/config/defaults.js #4684

Closed
rashidkpc opened this issue Aug 18, 2015 · 1 comment
Closed

Advanced settings require entry in src/ui/public/config/defaults.js #4684

rashidkpc opened this issue Aug 18, 2015 · 1 comment
Assignees
@epixa
Labels
good first issue low hanging fruit PR sent release_note:enhancement

Comments

@rashidkpc
Copy link
Contributor

Currently for a setting to show up it must appear in src/ui/public/config/defaults.js. This is inconvenient for plugins that want to interact with the config service. Unknown settings should show up, but be completely removed when the trash can icon is clicked
@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience good first issue low hanging fruit labels Aug 18, 2015
@epixa epixa self-assigned this Sep 11, 2015
@epixa
Copy link
Contributor

epixa commented Sep 11, 2015

The .kibana index currently keeps the buildNum inside the config as well. Is it safe to assume that users should not be able to modify that?

Are there any other known values that get dropped into config that we shouldn't let users modify?

@epixa epixa mentioned this issue Sep 11, 2015
Merged
@epixa epixa added PR sent release_note:enhancement and removed bug Fixes for quality problems that affect the customer experience labels Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epixa epixa

Labels
good first issue low hanging fruit PR sent release_note:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epixa @rashidkpc