Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Accessible Headers #48167

Closed
12 tasks done
kobelb opened this issue Oct 14, 2019 · 5 comments
Closed
12 tasks done

Security Accessible Headers #48167

kobelb opened this issue Oct 14, 2019 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kobelb
Copy link
Contributor

kobelb commented Oct 14, 2019 •
edited by myasonik
Loading

Per #37539, we'll want to audit all of the security screens and ensure we're using headers appropriately.

Login screen

  • no findings

User management screen

  • Main landmark must not be contained in another landmark (must be fixed by Management app)
  • Document must have 1 main landmark (must be fixed by Management app)
  • Ensure landmarks are unique (must be fixed by Management app)
  • Page must contain a level-one heading (Fixable by us!)

Role management screen

  • Main landmark must not be contained in another landmark (must be fixed by Management app)
  • Document must have 1 main landmark (must be fixed by Management app)
  • Ensure landmarks are unique (must be fixed by Management app)
  • Page must contain a level-one heading (Fixable by us!)

User account screen

  • Main landmark must not be contained in another landmark (must be fixed by Management app)
  • Document must have 1 main landmark (must be fixed by Management app)
  • Ensure landmarks are unique (must be fixed by Management app)
  • Heading levels should only increase by 1 (Fixable by us!)
@kobelb kobelb added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Oct 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kobelb kobelb added Project:Accessibility bug Fixes for quality problems that affect the customer experience labels Oct 14, 2019
@legrego legrego mentioned this issue Oct 16, 2019
Merged
@legrego
Copy link
Member

legrego commented Oct 16, 2019

Updated description to document my heading-related a11y findings to date

@barlowm barlowm mentioned this issue Nov 1, 2019
Closed
15 tasks
@rayafratkina rayafratkina mentioned this issue Nov 22, 2019
Closed
@rayafratkina
Copy link
Contributor

Depends on #51493

@kobelb kobelb mentioned this issue Nov 22, 2019
Merged
@kobelb
Copy link
Contributor Author

kobelb commented Nov 25, 2019

@rayafratkina all of the issues that we can fix have been addressed.

@myasonik
Copy link
Contributor

myasonik commented Dec 2, 2019

Just confirmed on master these look good

@myasonik myasonik closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kobelb @legrego @myasonik @elasticmachine @rayafratkina