Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces Accessible Headers #48168

Closed
7 tasks done
kobelb opened this issue Oct 14, 2019 · 6 comments
Closed
7 tasks done

Spaces Accessible Headers #48168

kobelb opened this issue Oct 14, 2019 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kobelb
Copy link
Contributor

kobelb commented Oct 14, 2019

Per #37539, we'll want to audit all of the spaces screens and ensure we're using headers appropriately.

Spaces Management

  • Main landmark must not be contained in another landmark (must be fixed by Management app)
  • Document must have 1 main landmark (must be fixed by Management app)
  • Ensure landmarks are unique (must be fixed by Management app)
  • Heading levels should only increase by 1 (Fixable by us!)

Space Selector

  • Main landmark must not be contained in another landmark (must be fixed by platform app rendering)
  • Document must have 1 main landmark (must be fixed by platform app rendering)
  • Ensure landmarks are unique (must be fixed by platform app rendering)
@kobelb kobelb added bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Oct 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Oct 16, 2019

I did a brief audit of the Spaces screens today. Most of our headings findings are outside of our control — both the management screens and the spaces selector are rendered within Kibana-provided markup, which we can’t control yet.

There are a couple of other quick fixes I can put a PR up for though, to at least get this initiative started. I’ll update the PR description so we can better track this progress

@kobelb
Copy link
Contributor Author

kobelb commented Oct 16, 2019

Thanks, Larry!

@rayafratkina
Copy link
Contributor

Depends on #51493

@kobelb
Copy link
Contributor Author

kobelb commented Nov 25, 2019

@rayafratkina all of the issues that we can fix should now be addressed.

@myasonik
Copy link
Contributor

myasonik commented Dec 2, 2019

Just confirmed on master these look good

@myasonik myasonik closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

5 participants