Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard edit button shown on mobile #49845

Closed
flash1293 opened this issue Oct 31, 2019 · 2 comments · Fixed by #50639
Closed

Dashboard edit button shown on mobile #49845

flash1293 opened this issue Oct 31, 2019 · 2 comments · Fixed by #50639
Assignees
Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v7.5.0

Comments

@flash1293
Copy link
Contributor

Kibana version: master

Describe the bug: Editing dashboards on mobile devices is not supported. Because of this the Edit menu button should be hidden if the viewport is too small (see #29896 ) It seems like this broke at some place. (Maybe during kbn-top-nav migration - ping @lizozom )

@flash1293 flash1293 added Feature:Dashboard Dashboard related features regression Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cchaos
Copy link
Contributor

cchaos commented Oct 31, 2019

This is a regression since 7.4. In Dashboards, we hide the "Edit" top nav item from mobile devices by passing down utility classes. This seems to have broken during the React-ification of the Top Nav component (#40262).

This is how we were passing down the class:

// We want to hide the "edit" button on small screens, since those have a responsive
// layout, which is not tied to the grid anymore, so we cannot edit the grid on that screens.
className: 'eui-hideFor--s eui-hideFor--xs',

And this is where is needs to be applied to the nav item.

const btn = (
<EuiButtonEmpty
size="xs"
isDisabled={isDisabled()}
onClick={handleClick}
data-test-subj={props.testId}
>
{capitalize(props.label || props.id!)}
</EuiButtonEmpty>
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features good first issue low hanging fruit regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v7.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants