Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid version check doesn't work for Legacy plugins #50785

Closed
mshustov opened this issue Nov 15, 2019 · 3 comments · Fixed by #54690
Closed

Invalid version check doesn't work for Legacy plugins #50785

mshustov opened this issue Nov 15, 2019 · 3 comments · Fixed by #54690
Assignees
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

Kibana version: master

Describe the bug:
Kibana doesn't disable plugins with invalid version, but crashes.

Steps to reproduce:

  1. create a plugin that cannot be used with the current Kibana version. For example, a plugin for 7.4.0
  2. start Kibana
  3. Kibana crashes

Expected behavior: Kibana starts and logs Plugin "${name}" was disabled because it expected Kibana version "${pluginVersion}", and found "${kibanaVersion}".

Provide logs and/or server output (if relevant):

  log   [16:49:46.009] [fatal][root] TypeError: Cannot read property 'version' of undefined
    at MapSubscriber.version (/Users/mikhailshustov/work/kibana/src/core/server/legacy/plugins/find_legacy_plugin_specs.ts:102:44)

fails on reading from https://github.com/restrry/kibana/blob/3131dd494d623c72690b4a6335f109d19e6d3cc3/src/core/server/legacy/plugins/find_legacy_plugin_specs.ts#L102

Any additional context: can be affected by recent changes #43433

@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc regression labels Nov 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@MorrieAtElastic
Copy link

What is the current status of this problem? Is a code fix planned? If so any idea when it will be available? Thanks

@pgayvallet
Copy link
Contributor

@MorrieAtElastic The issue has been prioritized and should be addressed before 7.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
5 participants