Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML ACS built using request's basePath instead of server's root base path #51337

Closed
kobelb opened this issue Nov 21, 2019 · 2 comments
Closed

SAML ACS built using request's basePath instead of server's root base path #51337

kobelb opened this issue Nov 21, 2019 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Authentication Platform Security - Authentication Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@kobelb
Copy link
Contributor

kobelb commented Nov 21, 2019 •
edited
Loading

Starting in Kibana 7.4, we're building the ACS URL and including the request's basePath:

kibana/x-pack/plugins/security/server/authentication/providers/saml.ts

Line 600 in ee175f1

return `${this.options.getServerBaseURL()}${this.options.basePath.get(
We should only be using the server's basePath here. This causes SAML auth to fail when the user is auth'ing against a space specific URL.

This can be worked around by using the xpack.security.authc.saml.realm setting instead of the xpack.security.public.* settings.
@kobelb kobelb added bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication labels Nov 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kobelb kobelb mentioned this issue Nov 21, 2019
Merged
@kobelb
Copy link
Contributor Author

kobelb commented Dec 5, 2019

Resolved by #51391

@kobelb kobelb closed this as completed Dec 5, 2019
@kobelb kobelb mentioned this issue Jan 21, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Authentication Platform Security - Authentication Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kobelb @elasticmachine