Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core docs should have consistent EOL symbol #53761

Closed
mshustov opened this issue Dec 23, 2019 · 2 comments · Fixed by #53815 or #55689
Closed

Core docs should have consistent EOL symbol #53761

mshustov opened this issue Dec 23, 2019 · 2 comments · Fixed by #53815 or #55689
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Dec 23, 2019 •
edited
Loading

From time to time I face the problem that yarn core:acceptApiChanges updates a bunch of unrelated files due to difference in EOL symbol. Example:

We should enforce the common format for EOL for the docs and make it platform-agnostic.
Possible solutions:
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Dec 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov mentioned this issue Dec 27, 2019
Merged
@mshustov
Copy link
Contributor Author

#53815 sets EOL format only for the docs created by api-extractor.
api-documenter config is still in experiment mode microsoft/rushstack#1366 (comment)

@mshustov mshustov reopened this Jan 13, 2020
@mshustov mshustov mentioned this issue Jan 13, 2020
Merged
4 tasks
@mshustov mshustov mentioned this issue Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
2 participants
@mshustov @elasticmachine