-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector creation - improve error messaging from server #54386
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Moving from |
Moving from |
The messages from config-schema can get overly wordy. We're really in need of a better solution for JS data validation, as config-schema is only intended for validating Kibana config values into TS-typed objects. It has a number of downsides including the types generated are read-only, so can't be reused for cases where we want construct data of the same shape to pass somewhere else (eg, tests). It also can cause issues if the validated objects are re-validated - durations turn into objects which when passed through the same validation again will fail. I don't think there's much use in trying to "fix" anything here - except perhaps extremely annoying messages that we see frequently - since we really need to replace what we're using. For those extremely annoying messages, we can provide custom validate methods which produce nicer messages than config-schema does. Leaving this open though, as I suspect we may get questions about the error messages in the future, and can point them here. |
Closing as no longer relevant. |
(Review feedback from docs team on the connectors UI)
#48959 adds a connector creation flyout where you fill a form, and submitting it calls the create action API. We display server-side validation errors, but the messaging is not always clear.
Here are two specific examples:
Example 1: webhook
Example 2: email
Is there a way to make these messages easier to read/understand to the user? Both are very
verbose, and the problem is not made clear.
xpack.actions.whitelistedHosts
documentation about the whitelisting setting (this page)?All the error messages should start with capital E - "Error validating..."
The text was updated successfully, but these errors were encountered: