Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace injected vars with exposeToBrowser #54497

Closed
flash1293 opened this issue Jan 10, 2020 · 3 comments
Closed

Replace injected vars with exposeToBrowser #54497

flash1293 opened this issue Jan 10, 2020 · 3 comments
Assignees
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 10, 2020

Kibana app code uses injected vars in several places. As described in #54376 all usages should be replaced by exposeToBrowser:

Done Injected Var Source Usage Action Plan PR
kbnDefaultAppId config key kibana.defaultAppId several places in kibana plugin, discover, dashboard_mode Move into kibana_legacy plugin and expose via contract #55937
disableWelcomeScreen config key kibana.disableWelcomeScreen home Move into home plugin, change to home.disableWelcomeScreen and map kibana.disableWelcomeScreen over with a deprecation warning (see src/core/server/config/deprecation/types.ts) #55937
- autocompleteTerminateAfter config key kibana.autocompleteTerminateAfter input control vis leave as is for now, will be handled by app arch
- autocompleteTimeout config key kibana.autocompleteTimeout input control vis leave as is for now, will be handled by app arch
timelionUiEnabled config key timelion.ui.enabled timelion Move into timelion and expose via contract
- emsTileLayerId - vega leave as is for now, will be handled by Maps
enableExternalUrls config key vega.enableExternalUrls vega Create vega NP plugin, expose via contract
telemetryEnabled config key telemetry.enabled home leave as is for now, will be handled by Pulse
telemetryBanner config key telemetry.allowChangingOptInStatus home leave as is for now, will be handled by Pulse
- esShardTimeout esConfig.shardTimeout,(src/legacy/core_plugins/elasticsearch/index.js)- exposed by es plugin? vega leave as is for now, will be handled by platform
graphSavePolicy config key xpack.graph.savePolicy graph move into graph and expose via contract
canEditDrillDownUrls config key xpack.graph.canEditDrillDownUrls graph move into graph and expose via contract
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Jan 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

flash1293 commented Jan 21, 2020

@ppisljar @Bargs The settings for autocompleteTerminateAfter and autocompleteTimeout are used for the suggestions in the search bar and for the input control vis. I'm not sure where they belong long-term. Should we move them to the data plugin (data.autocompleteTerminateAfter)? I'm also fine with splitting them up into inputControl.autocompleteTerminateAfter and data.autocompleteTerminateAfter.

Edit: Scratch that - just saw #46705 (comment)

@flash1293
Copy link
Contributor Author

Closing this as all config keys managed by the Kibana app team are migrated, the rest will be handled by the respective owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants