[SIEM] Detection engine: Create new rule should not validate input when going back

[cwurm]

To reproduce:

1. Create new rule, complete Define rule, click Continue
2. Now on About rule, try click Edit on Define rule
3. Can't go back because About rule is not yet filled out

Expected:

1. It should always be possible to go back in the rule editing dialogue

Screenshot:

[elasticmachine]

Pinging @elastic/siem (Team:SIEM)

[cwurm]

And when filling Name/Description, then going back to edit Define rule, then continuing again, Name/Description are now gone.

[XavierM]

And when filling Name/Description, then going back to edit Define rule, then continuing again, Name/Description are now gone.

I will add a dialog error to tell the user that they need to click on continue before going away from it

[XavierM]

But for the general of this issue, you should talk to @MichaelMarcialis.

[MichaelMarcialis]

Expected:

1. It should always be possible to go back in the rule editing dialogue

@cwurm: Thanks for the feedback. This is a valid point. The original reason for not allowing the user to leave a panel in any direction without having validation pass (both continuing forward or going back to edit) is because of a situation such as the following:

1. User completes step one and clicks continue. Step one validates, collapses and step two opens.
2. User completes step two and clicks continue. Step two validates, collapses and step three opens.
3. User clicks edit button on step one to go back and make changes. The changes entered are invalid, but the user doesn't notice or correct.
4. User clicks edit button on step two to go forward and make changes. Now the validation errors in step one are hidden from the user's view.

The requirement of validation before leaving a step in any direction was a quick fix suggested by me in order to prevent having to over complicate the UI with additional validation errors for when a step was collapsed. However, I see your point that the ability to always go backwards to edit quickly is an important one.

What if we just simply always treated any step past the user's current location as if it had never been validated and completed? This way, edit buttons wouldn't appear for any step forward from the user's current location. This way, the user is always required to click the continue buttons (which would trigger that step's validation) to proceed forward and can optionally click the edit button (which would no longer demand validation) to go back. Thoughts?

That said, I don't believe we have time to make any such changes before the 7.6 release. Perhaps we can consider this as an enhancement for the next release?

[cwurm]

What if we just simply always treated any step past the user's current location as if it had never been validated and completed? This way, edit buttons wouldn't appear for any step forward from the user's current location. This way, the user is always required to click the continue buttons (which would trigger that step's validation) to proceed forward and can optionally click the edit button (which would no longer demand validation) to go back. Thoughts?

Yes, I think this would work.

[spong]

@MadameSheema the behavior above is still present in 7.9.0-snapshot.

[MadameSheema]

Closing this ticket since it is duplicated.