Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIEM - UI text corrections #57270

Closed
benskelker opened this issue Feb 10, 2020 · 3 comments · Fixed by #57535
Closed

SIEM - UI text corrections #57270

benskelker opened this issue Feb 10, 2020 · 3 comments · Fixed by #57535
Assignees
@benskelker
Labels
Team:SIEM

Comments

@benskelker
Copy link
Contributor

Sorry for not noticing this earlier, but we need to fix the histogram titles whenever the word count is used:

  • Signals count > Signal count
  • External alerts count > External alert count
  • Events count > Event count

cc @MichaelMarcialis @MikePaquette

I can open a PR, whatever you prefer Michael.
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@MichaelMarcialis
Copy link
Contributor

I'm fine with this, as long as @MikePaquette also agrees. If you could create the PR, that would be most appreciated. Thanks!

@MikePaquette
Copy link

MikePaquette commented Feb 11, 2020 •
edited
Loading

👍 for changing to singular term ahead of "count"

@benskelker benskelker self-assigned this Feb 12, 2020
@benskelker benskelker mentioned this issue Feb 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benskelker benskelker

Labels
Team:SIEM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SIEM]Fixes UI titles for histograms benskelker/kibana
4 participants
@MichaelMarcialis @elasticmachine @MikePaquette @benskelker