Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hardening-tests of child_process.fork() once Node.js version is upgraded #59628

Closed
watson opened this issue Mar 9, 2020 · 1 comment · Fixed by #139222
Closed

Improve hardening-tests of child_process.fork() once Node.js version is upgraded #59628

watson opened this issue Mar 9, 2020 · 1 comment · Fixed by #139222
Labels
Feature:Hardening Harding of Kibana from a security perspective Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@watson
Copy link
Contributor

watson commented Mar 9, 2020 •
edited
Loading

Depends on #47968

In #55697, new tests are added that tests the hardening of the child_process module. Some tests of the fork function have been omitted as the version of Node.js that Kibana is currently running contains a bug which makes some corner-case testing of fork impossible (see TODO in #55697).

Once we upgrade to a newer version of Node.js, these tests should be added.
@watson watson added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Hardening Harding of Kibana from a security perspective labels Mar 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@watson watson mentioned this issue Mar 9, 2020
Merged
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@legrego legrego mentioned this issue Aug 22, 2022
Merged
@legrego legrego removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Hardening Harding of Kibana from a security perspective Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'fork' to child_process hardening tests legrego/kibana
3 participants
@watson @legrego @elasticmachine