Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactExpressionRenderer does not support custom ExpressionsService #59744

Closed
timroes opened this issue Mar 10, 2020 · 3 comments
Closed

ReactExpressionRenderer does not support custom ExpressionsService #59744

timroes opened this issue Mar 10, 2020 · 3 comments
Assignees
@streamich
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@timroes
Copy link
Contributor

timroes commented Mar 10, 2020 •
edited by streamich
Loading

There should be a way that the ReactExpressionRenderer can use a forked version of the ExpressionsService. Currently you cannot use the component with a fork. This is blocking #58333.

I think either the react component should accept an ExpressionsService as a property, or the ExpressionsService itself should have a property, for an already prebound ReactExpressionRenderer.

Parent issue: #46909
@timroes timroes added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Mar 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@timroes timroes mentioned this issue Mar 10, 2020
Closed
@streamich streamich mentioned this issue Mar 10, 2020
Closed
20 tasks
@streamich
Copy link
Contributor

streamich commented Mar 30, 2020 •
edited
Loading

Just leaving a note here for our planning: I think it is better to create a new component that uses ExpressionExecution directly. It should be easy to do as ExpressionExecution has a state container to which we can connect that new component. And that component could be a property on ExpressionService.

@streamich streamich mentioned this issue May 1, 2020
Closed
2 tasks
@streamich streamich mentioned this issue May 5, 2020
Closed
13 tasks
@streamich streamich self-assigned this May 5, 2020
@streamich
Copy link
Contributor

Closing this as we are moving away from using forks and instead function definition interface will be extended with additional info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@streamich streamich

Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timroes @streamich @elasticmachine