Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused index pattern methods #61766

Closed
lizozom opened this issue Mar 30, 2020 · 2 comments · Fixed by #78538
Closed

Clean up unused index pattern methods #61766

lizozom opened this issue Mar 30, 2020 · 2 comments · Fixed by #78538
Assignees
@mattkime @lizozom
Labels
v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Mar 30, 2020

Delete unused methods from index patterns:

  • indexPatterns.getFieldsForTimePattern, along with the _fields_for_time_pattern route
  • indexPattern.addScriptedField
  • isTimeBasedWildcard
  • toJSON
  • toString
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this issue Mar 30, 2020
Closed
1 task
@rayafratkina rayafratkina added v7.8.0 and removed v7.8 labels Apr 6, 2020
@mattkime mattkime added v7.9.0 and removed v7.8.0 labels May 10, 2020
@mattkime mattkime removed the v7.9.0 label Jul 14, 2020
@lizozom
Copy link
Contributor Author

lizozom commented Aug 31, 2020

@mattkime should we close this issue?

@mattkime mattkime linked a pull request Sep 25, 2020 that will close this issue
Index pattern class - remove unused methods #78538
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

@lizozom lizozom

Labels
v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Index pattern class - remove unused methods mattkime/kibana
4 participants
@mattkime @lizozom @elasticmachine @rayafratkina