Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Migrate Karma test to functional tests where necessary #67466

Closed
kertal opened this issue May 27, 2020 · 1 comment
Closed

[Discover] Migrate Karma test to functional tests where necessary #67466

kertal opened this issue May 27, 2020 · 1 comment
Labels
Feature:Discover Discover Application

Comments

@kertal
Copy link
Member

kertal commented May 27, 2020 •
edited
Loading

There are 3 Discover related test suites left in src/legacy/core_plugins/kibana/public/__tests__/discover
They are related to the legacy data table and should be analyzed whether they are still necessary, or already covered by functional tests. Where the tested use case isn't covered, functional tests should be created.
@kertal kertal added the Feature:Discover Discover Application label May 27, 2020
@kertal kertal self-assigned this May 27, 2020
@kertal kertal removed their assignment May 28, 2020
@flash1293 flash1293 mentioned this issue May 29, 2020
Closed
5 tasks
@kertal
Copy link
Member Author

kertal commented Jul 30, 2020 •
edited
Loading

Closing this because all tests have been migrated in the meantime , last one here #72649

@kertal kertal closed this as completed Jul 30, 2020
@kertal kertal changed the title [Discover] Migrate mocha test to functional tests where necessary [Discover] Migrate Karma test to functional tests where necessary Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Discover Discover Application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kertal