Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] Don't store part of drilldown state in Dashboard URL? #67982

Closed
Dosant opened this issue Jun 2, 2020 · 3 comments
Closed

[discuss] Don't store part of drilldown state in Dashboard URL? #67982

Dosant opened this issue Jun 2, 2020 · 3 comments
Labels
discuss Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Dosant
Copy link
Contributor

Dosant commented Jun 2, 2020

We are going to implement URL drilldown: #55324
Drilldown's configuration will contain a destination URL and we need to make sure dashboard app won't pick up random destination url from the dashboard url.

Option 1: Do not pick up drilldown destination url from dashboard URL

If we do this, how to not make user experience significantly worth?

Things we lose if remove part of state from URL:

  1. State where dashboard is still not saved?
  2. Sharing snapshot in edit mode?
  3. Undo / redo during editing?

Option 2: Rely on list of allowed domains

and do not change dashboard logic

We plan to implement allowed domains configuration.
Still under question if this should be opt-out or opt-in


This probably also related to: #59645, as visualization state will end up in the URL, and in case of markdown viz there could be urls.

@Dosant Dosant added discuss Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppArch Feature:Drilldowns Embeddable panel Drilldowns labels Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Jun 2, 2020
16 tasks
@Dosant Dosant closed this as completed Jun 4, 2020
@amberchandel
Copy link

Hi I am not getting the option of using the URL drill-down option in the dashboard as it is saying it is a beta version and insufficient license level please help!!

@amberchandel
Copy link

is it possible to use URL drill-down for a number range in the free version without having a gold license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants