Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] print warnings about circular dependencies between plugins #69200

Closed
spalger opened this issue Jun 15, 2020 · 2 comments
Closed
Assignees
Labels
Team:Operations Team label for Operations Team

Comments

@spalger
Copy link
Contributor

spalger commented Jun 15, 2020

In #68986 we almost removed the ability to have circular dependencies between plugins, but found the code changes necessary to get there to be too daunting. We are instead going to tackle them in chunks, after that PR is merged, but it would be useful if the @kbn/optimizer could warn users about the circular dependencies it detects. It might be pretty noisy, so we may want to make it opt-in, or limit the log messages to the bundles that were actually changed on build events after a watch. We might have trouble identifying circular deps between portions of a bundle, as all of the exports from a bundle might be totally independent, but have circular deps within that might cause issues... So some experimentation will be required.

@spalger spalger added the Team:Operations Team label for Operations Team label Jun 15, 2020
@spalger spalger self-assigned this Jun 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor

Believe this ask was completed by preventing circular dependencies here #82867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

3 participants