Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Url generator #69265

Closed
alvarezmelissa87 opened this issue Jun 16, 2020 · 4 comments
Closed

[ML] Url generator #69265

alvarezmelissa87 opened this issue Jun 16, 2020 · 4 comments
Assignees
Labels
enhancement New value added to drive a business result :ml v7.10.0

Comments

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Jun 16, 2020

Create a url generator that can be used in all the places in the ML plugin where URLs are being created in place or in scattered helper functions so that there is a central place where all that logic is being done.

This Url generator can also then be used by other plugins when they need to create ml URLs.

For example, something similar to the dashboard URL generator (src/plugins/dashboard/public/url_generator.ts) or jobs/components/custom_url_editor/utils.js
should work.

It should provide a solution for kibana issues open for this sort of URL generator functionality like:
#61785
#42845

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@streamich
Copy link
Contributor

streamich commented Jun 17, 2020

I more recent example would be Discover URL generator, take a look at that.

https://github.com/elastic/kibana/blob/master/src/plugins/discover/public/url_generator.ts

@peteharverson
Copy link
Contributor

peteharverson commented Jul 16, 2020

A URL generator has been added for 7.9.0 for the Anomaly Explorer in #71082. This needs to be enhanced to generate URLs for the other ML pages, including:

  • Single Metric Viewer
  • Anomaly Detection Job Management page
  • Data Frame Analytics Job Management page
  • Data Visualizer

@peteharverson
Copy link
Contributor

Closing as fixed by enhancements to MlUrlGenerator to extend to all ML pages for 7.10 in #75696.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result :ml v7.10.0
Projects
None yet
Development

No branches or pull requests

7 participants