Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nav] Custom plugin images that are url's do not display properly in the nav drawer #69691

Closed
cchaos opened this issue Jun 23, 2020 · 2 comments · Fixed by #69767
Closed

[Nav] Custom plugin images that are url's do not display properly in the nav drawer #69691

cchaos opened this issue Jun 23, 2020 · 2 comments · Fixed by #69767
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@cchaos
Copy link
Contributor

cchaos commented Jun 23, 2020

Ported from EUI:


My implementation is working fine till 7.6.x release. I am facing issue while migrating plugin to 7.7.x. I have attached my plugin screenshot of custom plugin icons. It looks bigger than default EUI icons. As per my analysis 'class="euiIcon euiIcon--medium euiIcon--app euiIcon-isLoaded euiListGroupItem__icon"' is not getting included for custom icon which are implemented using Icon property.

uiExports: {
app: {
title: 'SIP Analyzer',
description: 'An Awesome Kibana SIP Plugin',
main: mainFile,
icon: 'plugins/sip/resource/logo-scaled.png',
}
},

Html tags for custom plugin icon where above mention classes are not includes:

  • SIP Analyzer
  • plugin : https://github.com/BroadSoft-Xtended/BroadWorks-Dashboards-and-Discovery/blob/master/SIP-2.4.0_K_7.6.2.zip

    7 7 0

    Older version :
    7 6 0

    Originally posted by @parikshitgawali in elastic/eui#1690 (comment)

    @cchaos
    Copy link
    Contributor Author

    cchaos commented Jun 23, 2020

    I think I narrowed it down to this function

    function LinkIcon({ url }: { url: string }) {
    return <EuiImage size="s" alt="" aria-hidden={true} url={url} />;
    }

    EuiIcon supports custom url's as the iconType and so the nav drawer should continue to render it as an EuiIcon. Instead EuiImage with size='s' has an inherit size of 120x120px which is way too large.

    @cchaos cchaos added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Jun 23, 2020
    @elasticmachine
    Copy link
    Contributor

    Pinging @elastic/kibana-core-ui (Team:Core UI)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team
    Projects
    None yet
    Development

    Successfully merging a pull request may close this issue.

    2 participants