Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] perceived performance drop in /api/ingest_manager/epm/packages api response which is what loads Integrations to be added to a configuration #71289

Closed
EricDavisX opened this issue Jul 9, 2020 · 6 comments · Fixed by #79205
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@EricDavisX
Copy link
Contributor

Kibana version:
8.0 Cloud deploy

Browser OS version:
Chrome on macOS

Describe the bug:
I can't say this is a good performance test, but if we feel the hacky data presented here is enough we can do more formal tests and get instrumentation out (or stop-watches etc). I did a recording with what I had available, I acknowledge I didn’t even check which cloud-providers are in use and the stats of the machines!
... but I feel like with Google and 8.0 and the default cloud configuration over the last few weeks there was a point that it got slower. That's all I can say.

Steps to reproduce:
this is what I did, but is also theoretical, as I acknowledge above I don't have more instances spun up to compare better apples to apples

  1. open Ingest and go to the default configuration
  2. click on add Integration (add data source, in 7.8)
  3. see that the newer build takes longer to show the packages in the UI.

Expected behavior:
the package load time should be just as quick, or quicker.

Screenshots (if relevant):

integration-adding-list-timing.mov.zip

Screen Shot 2020-07-09 at 2 09 43 PM

@jen-huang
Copy link
Contributor

In 7.9, we added support for limiting integrations on an agent config (#70542). Part of this includes removing limited integrations which already exist on the selected agent config or disabling agent configs which already have that integration (depending on what is part of Step 1). This was accomplished via making an additional call to get the list of limited integrations (first request shown in the above screenshot), which will indeed slow down the initial loading of Step 1.

@EricDavisX Do you feel that the performance drop significantly degrades UX enough to warrant effort to improve it?

@ph I will remove beta1 label from this for now.

@jen-huang jen-huang added enhancement New value added to drive a business result and removed Ingest Management:beta1 labels Jul 16, 2020
@ph
Copy link
Contributor

ph commented Jul 16, 2020

@jen-huang if it doesn't have any bad side effect we push it to later releases. I am +1 to remove the beta label.

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jen-huang jen-huang removed their assignment Jul 21, 2020
@EricDavisX
Copy link
Contributor Author

I do think it warrants review. If any low hanging fruit exist to improve, I'd prioritize as high and try to get it in sooner. Anything harder is debatable.
I expect it will be a perceived bug, even if its the design, hence I'm skeptical of the 'enhancement' label
The attached video in a zip shows it takes about 6 seconds (will that continually get longer as we add more integrations?) which is long enough to give a bad experience. The question is, how fast is fast enough? I'm not sure what our UX best practices for UI response are, or any guidelines at least to target, best we can are.

@ph I'd put this on the list for 7.11. Unless you try it out and decide its ok enough. Personal repeat experience makes me want to fix it for 7.10. :)

@ph
Copy link
Contributor

ph commented Aug 27, 2020

@EricDavisX I am going to assign it to myself do a few testing.

@ph ph self-assigned this Aug 27, 2020
@jen-huang
Copy link
Contributor

I found a bug which would cause this page to be slow 🤦‍♀️ Reassigning to myself to fix.

@jen-huang jen-huang assigned jen-huang and unassigned ph Oct 1, 2020
@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants