Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent npm versions in package.json #7184

Closed
scampi opened this issue May 12, 2016 · 9 comments
Closed

inconsistent npm versions in package.json #7184

scampi opened this issue May 12, 2016 · 9 comments
Labels

Comments

@scampi
Copy link
Contributor

scampi commented May 12, 2016

In package.json the npm version is 2.15.1 in engines section, but it is 2.11.0 in the devDependencies section. Is this normal ?

@epixa
Copy link
Contributor

epixa commented May 12, 2016

Perhaps a better question is why are we even putting npm in our devDependencies? @rashidkpc git blame goes to you - is there a reason we're handling npm in this way?

@scampi
Copy link
Contributor Author

scampi commented May 24, 2016

any update on this ? ;o)

@epixa
Copy link
Contributor

epixa commented May 24, 2016

No update on this. I'll probably just remove it from devDependencies altogether, since it doesn't serve any purpose that I'm aware of.

@scampi
Copy link
Contributor Author

scampi commented Jun 1, 2016

it seems to be needed for the licenses task https://github.com/elastic/kibana/blob/master/tasks/licenses.js#L2

@epixa
Copy link
Contributor

epixa commented Jun 1, 2016

That'd do it.

@epixa
Copy link
Contributor

epixa commented Jun 1, 2016

Is this causing you an issue? It'd be good if those versions were in sync, so I'm totally down with it getting updated, but I also don't think it's outright necessary either.

@scampi
Copy link
Contributor Author

scampi commented Jun 1, 2016

No it is not causing an issue. I was curious why it is like that.

@epixa
Copy link
Contributor

epixa commented Jun 1, 2016

Cool! It seems to just be a mistake.

@cjcenizal
Copy link
Contributor

Resolved in #7526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants