Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Migrate to use track_total_hits. #71852

Closed
walterra opened this issue Jul 15, 2020 · 1 comment · Fixed by #78423
Closed

[ML] Migrate to use track_total_hits. #71852

walterra opened this issue Jul 15, 2020 · 1 comment · Fixed by #78423
Assignees

Comments

@walterra
Copy link
Contributor

We need to add track_total_hits: true to appropriate queries and adapt the code to retrieve the totalHits value. This means we need to switch over all the places where we use rest_total_hits_as_int to use track_total_hits, considering whether we need to use the exact hits total, or just an estimate.

More details: https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking-changes-7.0.html#hits-total-now-object-search-response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants