Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces app doesn't set its doc title #72672

Closed
cjcenizal opened this issue Jul 21, 2020 · 2 comments · Fixed by #91013
Closed

Spaces app doesn't set its doc title #72672

cjcenizal opened this issue Jul 21, 2020 · 2 comments · Fixed by #91013
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Spaces Platform Security - Spaces feature good first issue low hanging fruit Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@cjcenizal
Copy link
Contributor

Extracted from #69286. When the Spaces app mounts, it needs to call chrome.docTitle.change(PLUGIN_NAME);. When it unmounts, it needs to call chrome.docTitle.reset();. See #71045 for examples.

@cjcenizal cjcenizal added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Jul 21, 2020

Thanks for opening this, CJ! We're happy to take this on, but it almost feels like something the Management app should handle automatically for each of the registered "sub-apps". @mattkime what are your thoughts, does that sound feasible/reasonable?

I expect that some of the more complex apps would want to be able to control their own titles, but I would think that we can/should provide a reasonable default experience to reduce boilerplate in each of the sub-apps.

@legrego legrego added the good first issue low hanging fruit label Oct 22, 2020
@legrego legrego added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Spaces Platform Security - Spaces feature good first issue low hanging fruit Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants