-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Inventory view timeline #73962
Comments
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
@hbharding @sorantis can you take a look at this today/before Monday meeting and make sure it looks right to get started on this? |
Also: are we calling this a timeline view? I see "Timeline" has been removed from the latest mockup and it says "Hide history" ... do we have a decision on what we want to call it? |
re: "Timeline". Originally it said "Histogram", but I think @sorantis suggested Timeline, which sounds more descriptive. I realized afterwards that SIEM has a feature called Timeline, which might be a good reason to consider a different name. So I put "History" to start a discussion. It's been mentioned that this feature could be applicable to other Observability apps. Happy to go with whatever the team decides. |
I updated screenshot and removed what once said "Chart options". It was leftover design from an old idea. I was considering putting "time range" and "bucket span" inside a popover menu, as well as any other possible options. For instance, maybe the user wants to view a barchart instead of line, or change the colors in the chart, etc. Not necessary at the moment, but maybe something we do in the future if the bottom area becomes crowded with lots of options. Re: "time range" and "bucket span" - they serve 2 purposes.
I realize it might be problematic to load a years worth of data with 1 minute bucket intervals, so we likely need to limit bucket size based on the lookback period. I think we should discuss what the default resolution and lookback period should be, and what options we want to make available. i.e. Past day, Past week, etc. Also, perhaps we don't want to provide this as an option for our initial release if we think our default is good enough.
These options only affect the graph in the timeline section. The user does not see these options when the timeline is closed. |
@hbharding I've updated the AC based on conversations over the past few days. Can we have an updated mockup for the MVP version outlined in the current AC? |
@hbharding I just want to confirm we're changing |
This gives me the bucket size but I'm not sure how to get the time range from this? Should a 1 minute |
I've implemented it to chart the overall average across the currently displayed nodes. Is this expected behavior, or do we want it to chart data for the entire infrastructure? |
If no grouping is applied, then I think the expected behavior is correct - average across currently displayed nodes.
Thoughts? |
Oversight / mistake on my part. You can keep the text as it exists in the code now.
Yes - avg for the currently displayed nodes makes sense. I.e. if 1000 nodes exist, but there is a filter applied so only 10 nodes appear, the calculation should be based on the 10 visible nodes.
Good questions here. For simplicity, I think we should default to showing the past 24 hours of data in the timeline, regardless of the node's
Node "selected state" is out of scope for this ticket, but I think something like this could work in the future. If a node is selected inside a group, I might propose 3 curves: 1 for the avg across all groups, 1 for the avg across nodes in the "selected group", and 1 for the avg for the selected node. |
In preparation for viewing alerting and ML events over time in the inventory view, this ticket adds a timeline UI element to the bottom of that view.
Acceptance Criteria:
metricset.period
Not in scope for this ticket:
The text was updated successfully, but these errors were encountered: