Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] link-to node logs routes depend on the deprecated graphql source configuration API #74496

Closed
weltenwort opened this issue Aug 6, 2020 · 1 comment · Fixed by #74502
Assignees
Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0
Milestone

Comments

@weltenwort
Copy link
Member

Problem description

The logs/link-to/{container,host,pod}-logs routes still read the corresponding fields from the graphql-based source configuration API, because these fields are not available from the new plain JSON API.

Possible solutions

Two possible solutions come to mind:

  1. Add the three required field configurations to the response of the new log source configuration API.
  2. Remove the dependency of these fields by hard-coding them in the link-to redirects. This would break backwards-compatibility.
@weltenwort weltenwort added chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0 labels Aug 6, 2020
@weltenwort weltenwort added this to the Logs UI 7.10 milestone Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort changed the title [Logs UI] [Logs UI] link-to node logs routes depend on the deprecated graphql source configuration API Aug 6, 2020
@weltenwort weltenwort self-assigned this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants