Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection] Application Usage automatic schema #75329

Closed
afharo opened this issue Aug 18, 2020 · 4 comments · Fixed by #88080
Closed

[Usage Collection] Application Usage automatic schema #75329

afharo opened this issue Aug 18, 2020 · 4 comments · Fixed by #88080
Assignees
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Aug 18, 2020

This is an improvement over #70622.

In that issue, we added the usageCollection.schema option to help with the automation of the schema validation for every release.

This issue is to track the creation of some sort of automated process to update that schema with all the keys retrieved by checking all the requests to core.application.register and building up the schema dynamically.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed Team:KibanaTelemetry labels Dec 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo
Copy link
Member Author

afharo commented Dec 10, 2020

Ideally, we can move to an array format and simplify the schema a lot.

Another possibility is to provide the DYNAMIC_KEY keyword we previously agreed on with @mindbat.

Finally, we can run some functional tests that list all the apps in Kibana and check they are listed in the schema. The problem with this last approach is that it will depend on whether plugins are enabled/disabled while running the tests.

@afharo
Copy link
Member Author

afharo commented Dec 15, 2020

We can keep updating manually but add FTR that retrieves the list of apps from Core and checks the schema is up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants