Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make RenderCompleteDispatcher reactive #75417

Closed
3 tasks
streamich opened this issue Aug 19, 2020 · 1 comment
Closed
3 tasks

Make RenderCompleteDispatcher reactive #75417

streamich opened this issue Aug 19, 2020 · 1 comment
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@streamich
Copy link
Contributor

  • Make RenderCompleteDispatcher instances reactive—the should return an observable which reports the latest state of the element, whether it is still rendering, whether error happened, how may times it was rendered.
  • Remove loading and error fields from EmbeddableOutput.
  • Expose through embeddable the observable of RenderCompleteDispatcher that reports the state of rendering; and use that instead of loading and error fields of EmbeddableOutput.

See #74504 (comment)
Part of #71857
@streamich streamich added Feature:Embedding Embedding content via iFrame Team:AppArch labels Aug 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Aug 19, 2020
Closed
33 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@streamich @elasticmachine @vadimkibana