-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable packages & CLIs to read core configuration without starting the core server #76003
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
Is creating a new package really necessary? Would importing a standalone / autonomous config service from Moving the service to a package would mean decouple all the services from their config schema and associated types, as the 'core' config schemas would need to also be moved, which is something I would really like to avoid to be honest. The standalone service could also have the advantage to be preconfigured with core's deprecations. We won't be able to do it for deprecations registered by plugins, but this still seems like a significant upside. |
If we can make that work without introducing any circular dependencies, I'm all for it. Seems like a better first option to me 👍 |
@joshdover Should we close this? The APM need has need addressed with #77855 and when we last talked about it with @spalger, the need for the optimizer was not urgent. |
Fine by me, if anyone disagrees, please re-open |
There are several use cases that have come up which need to be able to read the kibana.yml configuration before the core server is started or without starting the server at all:
yarn start
(which does read from yml file and then passes into the CLI)Proposed Solution
src/core/config
into a new@kbn/config
package@kbn/config
packageWe may need to validate that importing this future
@kbn/config
package before initializing the APM agent will actually work correctly since this package itself also imports other code (Joi, for example). We may not have instrumentation on those packages, so we must make sure the impact radius of this is small enough to be acceptable.Another caveat is that config deprecations defined by Core or plugins will not be executed when using this bare
@kbn/config
package. We must ensure that any config deprecations that touch the config keys we move into this package are moved into@kbn/config
as well.The text was updated successfully, but these errors were encountered: