Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Refactor phase serialization logic and add tests #76267

Closed
jloleysens opened this issue Aug 31, 2020 · 2 comments
Closed

[ILM] Refactor phase serialization logic and add tests #76267

jloleysens opened this issue Aug 31, 2020 · 2 comments
Labels
chore Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@jloleysens
Copy link
Contributor

Logic for phase-specific validation, serialisation and deserialisation should should have the following work done:

  1. Moved into a folder called lib inside of application. Currently the code lives in x-pack/plugins/index_lifecycle_management/public/application/services/policies.
  2. Have validation-specific rules broken into smaller functions with documentation and tests added

Additional context
@jloleysens jloleysens added chore Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Aug 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@yuliacech
Copy link
Contributor

Closing this since the form serializer has been refactored in #83077.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuliacech @jloleysens @elasticmachine