Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Use EPR's Image.path which replaces Image.src #76380

Closed
jfsiii opened this issue Sep 1, 2020 · 2 comments · Fixed by #76434
Closed

[Ingest Manager] Use EPR's Image.path which replaces Image.src #76380

jfsiii opened this issue Sep 1, 2020 · 2 comments · Fixed by #76434
Assignees
@jfsiii
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jfsiii
Copy link
Contributor

jfsiii commented Sep 1, 2020 •
edited
Loading

Kibana changes required for elastic/package-registry#629

The registry-root-relative Image.src is renamed Image.path and Image.src is now package-root-relative / as-authored

e.g. from https://github.com/elastic/package-registry/pull/629/files#diff-977f05e7b5b1fb1f9d46aa963957b983L22-R23

-     "src": "/package/example/1.0.0/img/kibana-iptables.png",
+     "src": "/img/kibana-iptables.png",
+     "path": "/package/example/1.0.0/img/kibana-iptables.png",

Update code to use Image.path if both are present or fall back to Image.src if that's the only property available
@jfsiii jfsiii added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@jfsiii jfsiii mentioned this issue Sep 1, 2020
Merged
@ph ph assigned jfsiii Sep 1, 2020
@ph
Copy link
Contributor

ph commented Sep 1, 2020

@jfsiii Can you take a look at it? changes seem local and it would be good to have it soon.

@jfsiii jfsiii mentioned this issue Sep 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfsiii jfsiii

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ingest Manager] Use EPR's Image.path if available jfsiii/kibana
3 participants
@ph @jfsiii @elasticmachine