Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map] Enable Zoom with scroll wheel #7778

Closed
pickypg opened this issue Jul 20, 2016 · 9 comments
Closed

[Map] Enable Zoom with scroll wheel #7778

pickypg opened this issue Jul 20, 2016 · 9 comments
Assignees
Labels
Feature:Coordinate Map Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v5.4.0 WIP Work in progress

Comments

@pickypg
Copy link
Member

pickypg commented Jul 20, 2016

We should enable scrolling with the mouse wheel, like every other map out there.

Minor Downside: in a large dashboard, if you quickly scroll down it and end up with your mouse over the map, then you may end up zooming in/out on it. This is an edge case though and I think normal map behavior trumps accidental scrolling.

@epixa
Copy link
Contributor

epixa commented Jul 20, 2016

I don't think that's an edge case... I can't really imagine a scenario where a person won't encounter that behavior on any sizable dashboard. I suspect that's why it existed in the first place.

@epixa epixa added the discuss label Jul 20, 2016
@Bargs
Copy link
Contributor

Bargs commented Jul 20, 2016

I tend to agree with @epixa here. Saved searches or doc tables (or maybe both?) exhibit the same issue, and I find it really annoying when trying to scroll through a dashboard.

@pickypg
Copy link
Member Author

pickypg commented Jul 20, 2016

I guess I'm just a more focused scroller. :)

Maybe we should make it so that this is toggle-able (via the UI and a checkbox). But possibly we should come up with a solution that applies to all of them? Perhaps when you're scrolling the page outside, it can disable scrolling inside of any of those problem areas (maps included) for a hundred ms (or so) to stop users from accidentally scrolling there?

People that are used to mapping applications are used to scrolling in a map with the mouse wheel. I actually find it very bizarre not having it. It's like a touch screen computer with the touch screen disabled.

@Bargs
Copy link
Contributor

Bargs commented Jul 20, 2016

Yeah that's not a bad idea. I wonder if we could just enable scrolling when the map is in "focus", e.g. when the user has clicked, dragged, or otherwise interacted with the map in some way already.

@pickypg
Copy link
Member Author

pickypg commented Jul 22, 2016

To flesh out my idea a little more, if we start scrolling on the page, then maybe we can overlay an invisible <div> over the scrollable visualizations and only remove them after some humanly unnoticeable, but friendly timeout? I've never actually tried it, but I suspect it works.

@meenalluktuke
Copy link

+1

@kayrus
Copy link

kayrus commented Sep 30, 2016

We already parse tilemap options and at first glance it is easy to implement an option for scrollWheelZoom

@thomasneirynck thomasneirynck self-assigned this Oct 31, 2016
@thomasneirynck
Copy link
Contributor

+1

@stacey-gammon stacey-gammon added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement and removed discuss labels Oct 31, 2016
@jbudz
Copy link
Member

jbudz commented Nov 1, 2016

Related #2645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Coordinate Map Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement v5.4.0 WIP Work in progress
Projects
None yet
Development

No branches or pull requests

8 participants