Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service map: Add empty state #77886

Closed
sorenlouv opened this issue Sep 18, 2020 · 4 comments · Fixed by #78382
Closed

[APM] Service map: Add empty state #77886

sorenlouv opened this issue Sep 18, 2020 · 4 comments · Fixed by #78382
Assignees
Labels
Team:APM All issues that need APM UI Team support v7.10.0

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Sep 18, 2020

It's not possible to distinguish between "no data" and "data loading" because the canvas is empty either way.

Solution

Show an EuiEmptyPrompt component on the page with the following content;

Service maps - Empty state

Title: No services available.
Content: We can’t find any services to map within the currently selected time range and environment. Please try another range or check the environment selected. If you don’t have any services, please use our setup instructions to get started.

@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Sep 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist
Copy link
Contributor

formgeist commented Sep 18, 2020

We could start with showing a EuiEmptyPrompt component on the page with the following content;

Service maps - Empty state

Title: No services available.
Content: We can’t find any services to map within the currently selected time range and environment. Please try another range or check the environment selected. If you don’t have any services, please use our setup instructions to get started.

@sorenlouv
Copy link
Member Author

sorenlouv commented Sep 21, 2020

@formgeist Looks good. Should we convert this to an implementation issue or create a new one?
Edit: I've converted this into an implementation issue. Feel free to create a new one if that's better.

@formgeist
Copy link
Contributor

@sqren I think that's fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants