Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile Map dots too small when zoomed in #7882

Closed
LeeDr opened this issue Jul 28, 2016 · 6 comments
Closed

Tile Map dots too small when zoomed in #7882

LeeDr opened this issue Jul 28, 2016 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@LeeDr
Copy link
Contributor

LeeDr commented Jul 28, 2016

Kibana version: 4.1.11, 4.5.4, (any version supporting new Elastic Tile Service)

Elasticsearch version: 1.7.3 with Kibana 4.1.11

Server OS version: CentOS 7

Browser version: Firefox 45.2.0

Browser OS version: CentOS 7

Original install method (e.g. download page, yum, from source, etc.): un-tar

Description of the problem including expected versus actual behavior: We just added ability to zoom to level 10 in this release. But during testing, when zoomed all the way in, the dots seem too small. But maybe I just don't understand how the precision scales with the map levels.

Steps to reproduce:

  1. I'll paste a screenshot from each zoom level
  2. I'm not sure if the precision scales along with the zoom level of the maps, but it looks like the even numbered images below, especially 6, 8, and 10, have very small dots (higher precision) relative to the map than the odd images.

Image 1:
2016-07-28 13_35_32-oracle vm virtualbox manager

Image 2:
2016-07-28 13_36_06-onenote

Image 3:
2016-07-28 13_36_24-onenote

Image 4:
2016-07-28 13_36_42-onenote

Image 5:
2016-07-28 13_37_07-onenote

Image 6:
2016-07-28 13_37_27-onenote

Image 7:
2016-07-28 13_37_39-onenote

Image 8:
2016-07-28 13_38_00-onenote

Image 9:
2016-07-28 13_38_23-onenote

Image 10:
2016-07-28 13_38_39-onenote

@LeeDr LeeDr added bug Fixes for quality problems that affect the customer experience P2 labels Jul 28, 2016
@LeeDr
Copy link
Contributor Author

LeeDr commented Jul 28, 2016

I confirmed that the Tile Map request "precision" only increases every other zoom level. So that explains why the dots appear larger and smaller every other zoom level.

@LeeDr LeeDr added P3 and removed P2 labels Jul 28, 2016
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jul 29, 2016

Just to confirm, I can reproduce this on 5.0 as well.

@thomasneirynck
Copy link
Contributor

The scaling of the circle radii is based on a lot magic numbers. Also the scaling logic itself, appears somewhat ad hoc and not well-founded (cf. pointToLayer: and _radiusScale in scaled_circles.js) .

The scaling should likely be simplified to the following:

  • [a] the size of the circle cannot exceed that of the geohash-grid cell that the aggregation was computed for. The largest circle could expand to the full fize of the geohash grid cell.
  • [b] the size of the circle should be proportional to the size of the aggregate value

Regarding [a], the size of the dots bounces all over, often much too small for the corresponding geohash-cell. This issue describes one visual artifact of this.

Regarding [b], the circle-radius is now proportional to the square root of the aggregate value (+ some other weighting). This seems somewhat arbitrary.

@thomasneirynck
Copy link
Contributor

Another related issue is the ad-hoc way that Leaflet's zoom levels are mapped to a Geohash precision level. This mapping is now manually defined in agg_types/buckets/geo_hash.js.

These geohash-precision-levels seem to grow much too quickly as the map's zoom level increases. While geohash-precision levels do not map to Leaflet zoom-levels one-to-one (former subdivides with base 8, the latter with base 2), here too it may help to introduce some rigidity for a more predictable user experience. For example, a geohash-grid may not be smaller than some number of pixels.

@thomasneirynck
Copy link
Contributor

see also this user's screenshots, who has a similar issue with his data (geohash too precise for zoom level).

https://discuss.elastic.co/t/how-can-i-zoom-on-city/57972

@thomasneirynck
Copy link
Contributor

closed with #8000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

2 participants